Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep(3) Write grep { /$pattern/ } @list instead of grep /$pattern/, @list.


This Policy is part of the core Perl::Critic distribution.


The expression forms of "grep" and "map" are awkward and hard to read. Use the block forms instead.

    @matches = grep  /pattern/,    @list;        #not ok
    @matches = grep { /pattern/ }  @list;        #ok
    @mapped = map  transform($_),    @list;      #not ok
    @mapped = map { transform($_) }  @list;      #ok


This Policy is not configurable except for the standard options.


Jeffrey Ryan Thalhammer <[email protected]>


Copyright (c) 2005-2013 Imaginative Software Systems. All rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.